hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9137) Add Tag dictionary in WAL compression
Date Fri, 27 Sep 2013 18:01:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780166#comment-13780166
] 

Ted Yu commented on HBASE-9137:
-------------------------------

{code}
+ * Context that holds the dictionary for Tag compression and doing the compress/uncompress.
This
+ * will be used for compressing tags while writing into HFile and WALs.
{code}
As far as I can tell, TagCompressionContext is only used in WAL related classes. How is HFile
related ?
{code}
+  public TagCompressionContext(Class<? extends Dictionary> dictType) throws SecurityException,
{code}
Is wildcard necessary above ?
{code}
+    int endOffset = pos + tagsLength;
+    while (pos < endOffset) {
{code}
Add assertion that pos < endOffset before the while loop ?

There're 3 variants for uncompressTags(). Can you add javadoc for them explaining use case
?

More comments to follow once patch posted on rb.
                
> Add Tag dictionary in WAL compression
> -------------------------------------
>
>                 Key: HBASE-9137
>                 URL: https://issues.apache.org/jira/browse/HBASE-9137
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.98.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 0.98.0
>
>         Attachments: HBASE-9137.patch
>
>
> We can add tag dictionary like we have one for rowdictionary, familydictionary.  But
this has to be done after stabilizing HBASE-7391.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message