hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8870) Store.needsCompaction() should include minFilesToCompact
Date Thu, 26 Sep 2013 12:29:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778705#comment-13778705
] 

Hudson commented on HBASE-8870:
-------------------------------

FAILURE: Integrated in hbase-0.96-hadoop2 #59 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/59/])
HBASE-8870 Store.needsCompaction() should include minFilesToCompact (Liang Xie) (sershe: rev
1526343)
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
* /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java

                
> Store.needsCompaction() should include minFilesToCompact
> --------------------------------------------------------
>
>                 Key: HBASE-8870
>                 URL: https://issues.apache.org/jira/browse/HBASE-8870
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 0.95.1
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.0
>
>         Attachments: HBASE-8870.03.patch, HBASE-8870.txt, HBASE-8870.txt, HBase-8870-v2.txt
>
>
> read here:
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) > minFilesToCompact;
>   }
> {code}
> imho, it should be 
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) >= minFilesToCompact;
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message