Return-Path: 
 <issues-return-112841-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 728B710EF9
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed, 28 Aug 2013 22:47:54 +0000 (UTC)
Received: (qmail 18114 invoked by uid 500); 28 Aug 2013 22:47:53 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 18072 invoked by uid 500); 28 Aug 2013 22:47:53 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 18028 invoked by uid 99); 28 Aug 2013 22:47:53 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Aug 2013 22:47:53 +0000
Date: Wed, 28 Aug 2013 22:47:53 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12665808.1377641717567.50187.1377730073752@arcas>
In-Reply-To: <JIRA.12665808.1377641717567@arcas>
References: <JIRA.12665808.1377641717567@arcas>
Subject: [jira] [Commented] (HBASE-9359) Convert KeyValue to Cell in
 hbase-client module - Result/Put/Delete, ColumnInterpreter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752973#comment-13752973 ] 

stack commented on HBASE-9359:
------------------------------

bq.  I'm leaning towards making sure the commonly used but inefficient KeyValue methods (including #getQualifier, #getFamily, and #getValue, and #getRow) get ported into the Cell interface. 

getFamily, etc., are out in CellUtil rather than in Cell currently?  Their addition is pure convenience and bloats the Cell Interface and my fear is users would start to lean on these new methods rather than work harder to use the methods that do not require us make a copy ([~mcorgan] you have an opinion here boss?)  On other hand, smooths the transition to the Interface, a difficult transition to make.

bq. For the shim to handle the List<KeyValue> -> List<Cell> conversion, I'm going to use a naive array copy.

Ouch.  Put big warnings on deprecated methods that this is what is going on I'd say.

bq. By having it as a List<Cell> we can read and write in elements that are subclasses of Cell as long as we only use the Cell interface.

Ok

Let me take a looksee.
                
> Convert KeyValue to Cell in hbase-client module - Result/Put/Delete, ColumnInterpreter
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-9359
>                 URL: https://issues.apache.org/jira/browse/HBASE-9359
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 0.95.2
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9359.patch, hbase-9359.v2.patch
>
>
> This path is the second half of eliminating KeyValue from the client interfaces.  This percolated through quite a bit. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira