Return-Path: 
 <issues-return-109996-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 92E871067D
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue, 13 Aug 2013 23:20:48 +0000 (UTC)
Received: (qmail 46789 invoked by uid 500); 13 Aug 2013 23:20:48 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 46750 invoked by uid 500); 13 Aug 2013 23:20:48 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 46741 invoked by uid 99); 13 Aug 2013 23:20:48 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Aug 2013 23:20:48 +0000
Date: Tue, 13 Aug 2013 23:20:48 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12663509.1376426662236.59843.1376436048277@arcas>
In-Reply-To: <JIRA.12663509.1376426662236@arcas>
References: <JIRA.12663509.1376426662236@arcas>
Subject: [jira] [Commented] (HBASE-9208) ReplicationLogCleaner slow at large
 scale
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739001#comment-13739001 ] 

Lars Hofhansl commented on HBASE-9208:
--------------------------------------

Sounds good. Can you post the patch, [~davelatham]?
                
> ReplicationLogCleaner slow at large scale
> -----------------------------------------
>
>                 Key: HBASE-9208
>                 URL: https://issues.apache.org/jira/browse/HBASE-9208
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Dave Latham
>             Fix For: 0.94.12
>
>
> At a large scale the ReplicationLogCleaner fails to clean up .oldlogs as fast as the cluster is producing them.  For each old HLog file that has been replicated and should be deleted the ReplicationLogCleaner checks every replication queue in ZooKeeper before removing it.  This means that as a cluster scales up the number of files to delete scales as well as the time to delete each file so the cleanup chore scales quadratically.  In our case it reached the point where the oldlogs were growing faster than they were being cleaned up.
> We're now running with a patch that allows the ReplicationLogCleaner to refresh its list of files in the replication queues from ZooKeeper just once for each batch of files the CleanerChore wants to evaluate.
> I'd propose updating FileCleanerDelegate to take a List<FileStatus> rather than a single one at a time.  This would allow file cleaners that check an external resource for references such as ZooKeeper (for ReplicationLogCleaner) or HDFS (for SnapshotLogCleaner which looks like it may also have similar trouble at scale) to load those references once per batch rather than for every log.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira