Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6262010603 for ; Wed, 14 Aug 2013 22:17:52 +0000 (UTC) Received: (qmail 13116 invoked by uid 500); 14 Aug 2013 22:17:51 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 13081 invoked by uid 500); 14 Aug 2013 22:17:51 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 13034 invoked by uid 99); 14 Aug 2013 22:17:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Aug 2013 22:17:51 +0000 Date: Wed, 14 Aug 2013 22:17:51 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9196) Remove dead code related to KeyValue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740287#comment-13740287 ] Hudson commented on HBASE-9196: ------------------------------- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #675 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/675/]) HBASE-9196 Remove dead code related to KeyValue (jmhsieh: rev 1513964) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/RedundantKVGenerator.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/PrefixTreeCodec.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlusher.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java > Remove dead code related to KeyValue > ------------------------------------ > > Key: HBASE-9196 > URL: https://issues.apache.org/jira/browse/HBASE-9196 > Project: HBase > Issue Type: Bug > Affects Versions: 0.96.0 > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > Fix For: 0.95.2, 0.96.0 > > Attachments: hbase-9164.patch, hbase-9196.v2.patch, hbase-9196.v3.95.patch, hbase-9196.v3.patch > > > While working on HBASE-9164, I found some deprecated and dead code. > 1) two volatiles variables were in the critical path for comparators. (ignoreTimetamps and ignoreTypes). Removed them. > 2) Replaced references to deprected #getMemstoreTs with #getMvccVersion > 3) Removed ROOT_KEY_COMPARATOR and references. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira