Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 14 Aug 2013 13:53:48 +0000 (UTC)
From: "Jonathan Hsieh (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12663313.1376349996163.64264.1376488428107@arcas>
In-Reply-To: <JIRA.12663313.1376349996163@arcas>
References: <JIRA.12663313.1376349996163@arcas>
Subject: [jira] [Commented] (HBASE-9196) Remove dead code related to
 KeyValue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739677#comment-13739677 ] 

Jonathan Hsieh commented on HBASE-9196:
---------------------------------------

The -1 from site failure is due to 

{code}
...
[INFO] Generating "Dependency Convergence" report    --- maven-project-info-reports-plugin:2.7
[INFO] Generating "Plugin Management" report    --- maven-project-info-reports-plugin:2.7
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (malloc) failed to allocate 65544 bytes for Chunk::new
# An error report file with more information is saved as:
# /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hs_err_pid30848.log
{code}

It passes for me locally.  Giving it another try.
                
> Remove dead code related to KeyValue
> ------------------------------------
>
>                 Key: HBASE-9196
>                 URL: https://issues.apache.org/jira/browse/HBASE-9196
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9164.patch, hbase-9196.v2.patch
>
>
> While working on HBASE-9164, I found some deprecated and dead code.
> 1) two volatiles variables were in the critical path for comparators.  (ignoreTimetamps and ignoreTypes).  Removed them.
> 2) Replaced references to deprected #getMemstoreTs with #getMvccVersion
> 3) Removed ROOT_KEY_COMPARATOR and references.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira