Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 19 Aug 2013 23:26:52 +0000 (UTC)
From: "Himanshu Vashishtha (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12663308.1376349433375.127.1376954812416@arcas>
In-Reply-To: <JIRA.12663308.1376349433375@arcas>
References: <JIRA.12663308.1376349433375@arcas>
Subject: [jira] [Commented] (HBASE-9195) TestFSHDFSUtils is too aggressive
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744497#comment-13744497 ] 

Himanshu Vashishtha commented on HBASE-9195:
--------------------------------------------

So, 10ms wait was a red herring. The root cause was tests were getting re-ordered (java 7), and the property hbase.lease.recovery.dfs.timeout was getting overwritten by testIsFileClosed. Attached is the patch that fixes the issue. I will update the description of the jira. 
                
> TestFSHDFSUtils is too aggressive
> ---------------------------------
>
>                 Key: HBASE-9195
>                 URL: https://issues.apache.org/jira/browse/HBASE-9195
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.95.1
>            Reporter: Himanshu Vashishtha
>            Priority: Minor
>         Attachments: HBase-9195.patch, HBase-9195.patch
>
>
> The recoverLease test in this class sets hbase.lease.recovery.pause to 10ms. It causes that after every 10 ms, it calls isFileClosed (if it is available). Though the test takes only 3-4 sec, but it makes about 270 isFileClosed calls. This cause test to become somewhat flaky in our internal testing.
> The proposed fix is to just to increase the pause interval to 100 ms. This reduces the number of calls to about 30.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira