Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 8 Aug 2013 23:59:48 +0000 (UTC)
From: "Jimmy Xiang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12662745.1376006296733.29361.1376006388345@arcas>
In-Reply-To: <JIRA.12662745.1376006296733@arcas>
References: <JIRA.12662745.1376006296733@arcas>
Subject: [jira] [Commented] (HBASE-9167) ServerCallable retries just once if
 timeout is not integer.max
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734213#comment-13734213 ] 

Jimmy Xiang commented on HBASE-9167:
------------------------------------

We can backport HBASE-7756 and other changes from trunk.
                
> ServerCallable retries just once if timeout is not integer.max
> --------------------------------------------------------------
>
>                 Key: HBASE-9167
>                 URL: https://issues.apache.org/jira/browse/HBASE-9167
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.94.10
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>
> If callTimeout is not integer.max and throwable is not SocketTimeoutException, we set the callTimeout to a negative value since endTime is not set yet.  Therefore, the next call will always throw SocketTimeoutException.
> {noformat}
>     if (this.callTimeout != HConstants.DEFAULT_HBASE_CLIENT_OPERATION_TIMEOUT)
>       if (throwable instanceof SocketTimeoutException
>           || (this.endTime - this.startTime > this.callTimeout)) {
>         throw (SocketTimeoutException) (SocketTimeoutException) new SocketTimeoutException(
>             "Call to access row '" + Bytes.toString(row) + "' on table '"
>                 + Bytes.toString(tableName)
>                 + "' failed on socket timeout exception: " + throwable)
>             .initCause(throwable);
>       } else {
>    ===>     this.callTimeout = ((int) (this.endTime - this.startTime));
>       }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira