Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2300E10D95 for ; Fri, 2 Aug 2013 22:55:50 +0000 (UTC) Received: (qmail 76085 invoked by uid 500); 2 Aug 2013 22:55:49 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 76046 invoked by uid 500); 2 Aug 2013 22:55:49 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 76005 invoked by uid 99); 2 Aug 2013 22:55:49 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Aug 2013 22:55:49 +0000 Date: Fri, 2 Aug 2013 22:55:49 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9123) Filter protobuf generated code from long line warning MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728223#comment-13728223 ] Ted Yu commented on HBASE-9123: ------------------------------- Here is the difference between filtered and unfiltered long line warning based on PreCommit build #6569 : {code} TYus-MacBook-Pro:94-hbase tyu$ grep -v 'hbase.protobuf.generated' long-line-6569.txt | wc 60 488 7268 TYus-MacBook-Pro:94-hbase tyu$ wc long-line-6569.txt 1622 7597 211734 long-line-6569.txt {code} > Filter protobuf generated code from long line warning > ----------------------------------------------------- > > Key: HBASE-9123 > URL: https://issues.apache.org/jira/browse/HBASE-9123 > Project: HBase > Issue Type: Test > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Minor > Fix For: 0.98.0 > > Attachments: 9123.patch > > > For big patch, such as the one for namespace, there would be many changes in the protobuf generated code. > See example here: https://builds.apache.org/job/PreCommit-HBASE-Build/6569/console > We should filter protobuf generated code from long line warning -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira