Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD6DB10AC3 for ; Wed, 28 Aug 2013 20:50:52 +0000 (UTC) Received: (qmail 12928 invoked by uid 500); 28 Aug 2013 20:50:52 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 12886 invoked by uid 500); 28 Aug 2013 20:50:52 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12877 invoked by uid 99); 28 Aug 2013 20:50:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Aug 2013 20:50:52 +0000 Date: Wed, 28 Aug 2013 20:50:52 +0000 (UTC) From: "Jesse Yates (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9101) Addendum to pluggable RpcScheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752831#comment-13752831 ] Jesse Yates commented on HBASE-9101: ------------------------------------ +1 on stack's comments. We really should add a comment in HConstants that generally constants shouldn't go there, unless referenced by a lot of different things. Otherwise, ltgm. > Addendum to pluggable RpcScheduler > ---------------------------------- > > Key: HBASE-9101 > URL: https://issues.apache.org/jira/browse/HBASE-9101 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC > Reporter: Chao Shi > Assignee: Chao Shi > Fix For: 0.98.0 > > Attachments: hbase-9101.patch, hbase-9101-v2.patch > > > This patch fixes the review comments from [~stack] and a small fix: > - Make RpcScheduler fully pluggable. One can write his/her own implementation and add it to classpath and specify it by config "hbase.region.server.rpc.scheduler.factory.class". > - Add unit tests and fix that RpcScheduler.stop is not called (discovered by tests) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira