Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 8 Aug 2013 17:27:51 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12660841.1375235548367.26346.1375982871087@arcas>
In-Reply-To: <JIRA.12660841.1375235548367@arcas>
References: <JIRA.12660841.1375235548367@arcas>
Subject: [jira] [Commented] (HBASE-9098) During recovery use ZK as the
 source of truth for region state
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733716#comment-13733716 ] 

Ted Yu commented on HBASE-9098:
-------------------------------

{code}
+        || op == Operation.COMPACT_REGION) {
+      // split, merge or compact region doesn't need to check the closing/closed state or lock the
{code}
Why was COMPACT_REGION added to the above check ?
{code}
+      // use one element array in order for waitUntilRegionOnline to pass inRecovering state out
+      boolean[] isRecovering = new boolean[] { true };
{code}
You can also use AtomicBoolean above.
{code}
+        // been being moved to somewhere before hosting RS fails
{code}
'being' is redundant.
                
> During recovery use ZK as the source of truth for region state 
> ---------------------------------------------------------------
>
>                 Key: HBASE-9098
>                 URL: https://issues.apache.org/jira/browse/HBASE-9098
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.95.0
>            Reporter: Devaraj Das
>            Assignee: Jeffrey Zhong
>            Priority: Blocker
>             Fix For: 0.95.2
>
>         Attachments: hbase-9098.patch, hbase-9098-v1.patch, hbase-9098-v3.patch
>
>
> In HLogSplitter:locateRegionAndRefreshLastFlushedSequenceId(HConnection, byte[], byte[], String), we talk to the replayee regionserver to figure out whether a region is in recovery or not. We should look at ZK only for this piece of information (since that is the source of truth for recovery otherwise).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira