Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 23 Aug 2013 03:23:51 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12648063.1368742185247.21355.1377228231790@arcas>
In-Reply-To: <JIRA.12648063.1368742185247@arcas>
References: <JIRA.12648063.1368742185247@arcas>
Subject: [jira] [Commented] (HBASE-8565) stop-hbase.sh clean up: backup
 master
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748247#comment-13748247 ] 

Lars Hofhansl commented on HBASE-8565:
--------------------------------------

It's not currently broken, right? For 0.94 I'd be worried that this will create "surprises".
                
> stop-hbase.sh clean up: backup master
> -------------------------------------
>
>                 Key: HBASE-8565
>                 URL: https://issues.apache.org/jira/browse/HBASE-8565
>             Project: HBase
>          Issue Type: Bug
>          Components: master, scripts
>    Affects Versions: 0.94.7, 0.95.0
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Minor
>             Fix For: 0.98.0, 0.94.12, 0.96.0
>
>         Attachments: HBASE-8565-v1-0.94.patch, HBASE-8565-v1-trunk.patch
>
>
> In stop-hbase.sh:
> {code}
>   # TODO: store backup masters in ZooKeeper and have the primary send them a shutdown message
>   # stop any backup masters
>   "$bin"/hbase-daemons.sh --config "${HBASE_CONF_DIR}" \
>     --hosts "${HBASE_BACKUP_MASTERS}" stop master-backup
> {code}
> After HBASE-5213, stop-hbase.sh -> hbase master stop will bring down the backup master too via the cluster status znode.
> We should not need the above code anymore.
> Another issue happens when the current master died and the backup master became the active master.
> {code}
> nohup nice -n ${HBASE_NICENESS:-0} "$HBASE_HOME"/bin/hbase \
>    --config "${HBASE_CONF_DIR}" \
>    master stop "$@" > "$logout" 2>&1 < /dev/null &
> waitForProcessEnd `cat $pid` 'stop-master-command'
> {code}
> We can still issue 'hbase-stop.sh' from the old master.
> stop-hbase.sh -> hbase master stop -> look for active master -> request shutdown
> This process still works.
> But the waitForProcessEnd statement will not work since the local master pid is not relevant anymore.
> What is the best way in the this case?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira