Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3BB7C1072F for ; Tue, 13 Aug 2013 00:25:52 +0000 (UTC) Received: (qmail 76974 invoked by uid 500); 13 Aug 2013 00:25:48 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 76932 invoked by uid 500); 13 Aug 2013 00:25:48 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 76894 invoked by uid 99); 13 Aug 2013 00:25:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Aug 2013 00:25:48 +0000 Date: Tue, 13 Aug 2013 00:25:48 +0000 (UTC) From: "Gustavo Anatoly (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737613#comment-13737613 ] Gustavo Anatoly commented on HBASE-7462: ---------------------------------------- Hi, Nicolas and Stack. Firstly sorry for delay, to submit a solution. My proposal is: http://goo.gl/CK4dLY and I could substitute the old tests on TestDrainingServer for the test above? > TestDrainingServer is an integration test. It should be a unit test instead > --------------------------------------------------------------------------- > > Key: HBASE-7462 > URL: https://issues.apache.org/jira/browse/HBASE-7462 > Project: HBase > Issue Type: Wish > Components: test > Affects Versions: 0.95.2 > Reporter: Nicolas Liochon > Assignee: Gustavo Anatoly > Priority: Trivial > Labels: noob > Attachments: HBASE-7462-v1.patch > > > TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. > As it is written today, it's an integration test: it starts & stops a cluster. > The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira