hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-9408) Fix proto for ServerName so startcode cannot be negative
Date Sat, 31 Aug 2013 22:16:51 GMT
stack created HBASE-9408:

             Summary: Fix proto for ServerName so startcode cannot be negative
                 Key: HBASE-9408
                 URL: https://issues.apache.org/jira/browse/HBASE-9408
             Project: HBase
          Issue Type: Bug
          Components: Protobufs
    Affects Versions: 0.96.0
            Reporter: stack
            Assignee: stack
             Fix For: 0.98.0, 0.96.1

>From Devaraj on the mailing list:

On Sat, Aug 31, 2013 at 11:23 AM, Devaraj Das <ddas@hortonworks.com> wrote:
Thanks for making the RC, Stack. I bumped into one thing which I thought I
should bring up in the context of singularity - the ServerName message in
hbase.proto should have the start_code as a signed int. We allow for -1 (
ServerName.NON_STARTCODE) as a start_code. Hence.. Yes it can be worked
around, and, maybe there won't any wire-compat issues if we make the change
later (not sure about it) but I think we should fix it now. What do you

For illustration, here is the proposed fix.

diff --git a/hbase-protocol/src/main/protobuf/hbase.proto
index 08061e5..2f9a8d1 100644
--- a/hbase-protocol/src/main/protobuf/hbase.proto
+++ b/hbase-protocol/src/main/protobuf/hbase.proto
@@ -120,7 +120,7 @@ enum CompareType {
 message ServerName {
   required string host_name = 1;
   optional uint32 port = 2;
-  optional uint64 start_code = 3;
+  optional int64 start_code = 3;

Will make this fix in next RC if there is one.  Filing against 0.96.1 for now.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message