hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9359) Convert KeyValue to Cell in hbase-client module - Result/Put/Delete, ColumnInterpreter
Date Wed, 28 Aug 2013 22:47:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752973#comment-13752973
] 

stack commented on HBASE-9359:
------------------------------

bq.  I'm leaning towards making sure the commonly used but inefficient KeyValue methods (including
#getQualifier, #getFamily, and #getValue, and #getRow) get ported into the Cell interface.


getFamily, etc., are out in CellUtil rather than in Cell currently?  Their addition is pure
convenience and bloats the Cell Interface and my fear is users would start to lean on these
new methods rather than work harder to use the methods that do not require us make a copy
([~mcorgan] you have an opinion here boss?)  On other hand, smooths the transition to the
Interface, a difficult transition to make.

bq. For the shim to handle the List<KeyValue> -> List<Cell> conversion, I'm
going to use a naive array copy.

Ouch.  Put big warnings on deprecated methods that this is what is going on I'd say.

bq. By having it as a List<Cell> we can read and write in elements that are subclasses
of Cell as long as we only use the Cell interface.

Ok

Let me take a looksee.
                
> Convert KeyValue to Cell in hbase-client module - Result/Put/Delete, ColumnInterpreter
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-9359
>                 URL: https://issues.apache.org/jira/browse/HBASE-9359
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 0.95.2
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9359.patch, hbase-9359.v2.patch
>
>
> This path is the second half of eliminating KeyValue from the client interfaces.  This
percolated through quite a bit. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message