hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9346) HBCK should provide an option to check if regions boundaries are the same in META and in stores.
Date Thu, 29 Aug 2013 16:08:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753766#comment-13753766
] 

Ted Yu commented on HBASE-9346:
-------------------------------

RegionBoundariesInformation can be private.

There're long lines in checkRegionBoundaries()

Please remove the space between method name and ().

Do you need to instantiate RegionBoundariesInformation in every iteration of the loop ?
{code}
+              HFile.Reader reader = HFile.createReader(fs, storeFile.getPath(), new CacheConfig(getConf()));
{code}
Can you close the reader at the end of the inner loop ?
                
> HBCK should provide an option to check if regions boundaries are the same in META and
in stores.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9346
>                 URL: https://issues.apache.org/jira/browse/HBASE-9346
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.95.2, 0.94.11
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>         Attachments: HBASE-9346-v0-0.94.patch, HBASE-9346-v1-trunk.patch
>
>
> If META don't have the same region boundaries as the stores files, writes and read might
go to the wrong place. We need to provide a way to check that withing HBCK.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message