hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9334) Convert KeyValue to Cell in hbase-client module - Filters
Date Wed, 28 Aug 2013 17:40:54 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752613#comment-13752613
] 

Jonathan Hsieh commented on HBASE-9334:
---------------------------------------

Here's the key change for deprecation and compatibility (there are corresponding changes in
FilterBase and FilterWrapper)
{code}
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java
index 253b24d..3c491d3 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java
@@ -25,6 +25,7 @@ import java.util.List;
 import org.apache.hadoop.classification.InterfaceAudience;
 import org.apache.hadoop.classification.InterfaceStability;
 import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.KeyValue;
 import org.apache.hadoop.hbase.exceptions.DeserializationException;
 
 /**
@@ -192,6 +193,9 @@ public abstract class Filter {
    */
   abstract public boolean filterRow() throws IOException;
 
+  @Deprecated // use Cell GetNextKeyHint(final Cell)
+  abstract public KeyValue getNextKeyHint(final KeyValue currentKV) throws IOException;
+  
   /**
    * If the filter returns the match code SEEK_NEXT_USING_HINT, then it should also tell
which is
    * the next key it must seek to. After receiving the match code SEEK_NEXT_USING_HINT, the
{code}
                
> Convert KeyValue to Cell in hbase-client module - Filters
> ---------------------------------------------------------
>
>                 Key: HBASE-9334
>                 URL: https://issues.apache.org/jira/browse/HBASE-9334
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 0.95.2
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9334.patch, hbase-9334.v2.patch
>
>
> The goal is is to remove KeyValue from the publicly exposed API and require clients to
use the cleaner mroe encapsulated Cell API instead.  For filters, this affects #filterKeyValue,
#transform, #filterrow, and #getNextKeyHint.
> Since Cell is a base interface for KeyValue, changing these means that 0.94 apps may
need a recompile but probably no modifications. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message