hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9299) Generate the protobuf classes with hadoop-maven-plugin
Date Mon, 26 Aug 2013 21:15:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750557#comment-13750557
] 

Hadoop QA commented on HBASE-9299:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12599614/HBASE-9299.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings
(more than the trunk's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6903//console

This message is automatically generated.
                
> Generate the protobuf classes with hadoop-maven-plugin
> ------------------------------------------------------
>
>                 Key: HBASE-9299
>                 URL: https://issues.apache.org/jira/browse/HBASE-9299
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Eric Charles
>            Assignee: Eric Charles
>             Fix For: 0.98.0, 0.96.0
>
>         Attachments: HBASE-9299.patch
>
>
> For now, the protobuf classes are generated once by a dev, and put in src/main/resouce.

> This allows the other dev to not have the correct protoc version available on their machine.
However, when a dev wants to modify the protoc messages, he has to know how to generate the
classes. This could be documented...
> Another approach would be to put a harder requirement on the hbase developers (protoc
available) and let the hadoop-maven-plugin (http://central.maven.org/maven2/org/apache/hadoop/hadoop-maven-plugins/2.0.5-alpha)
to do the work (I have bad experience with other maven protobuf plugins, the hadoop one works
just out of the box).
> I don't think asking to install protoc to build hbase is so difficult, but that's an
additional step between the dev and the artifcat.
> The advantage would be to allow to have different protobuf versions for different hbase
distributions (perfectly possible but quite theorical).
> So
> option 1: We are happy to keep the classes in src/main/java
> option 2: We want to move to hadoop-maven-plugin 
> option 3: I may be short of idea... any other input?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message