hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9299) Generate the protobuf classes with hadoop-maven-plugin
Date Thu, 22 Aug 2013 18:11:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747736#comment-13747736
] 

Nicolas Liochon commented on HBASE-9299:
----------------------------------------

bq. http://hbase.apache.org/book/developer.html should also contain a section that explains
how protobuf is used and what to do in case of change, and link to the README in the src.
+1. I think the readme should be there.

bq. http://hbase.apache.org/book/developer.html should also contain a section that explains
how protobuf is used and what to do in case of change, and link to the README in the src.
If protobuf allows it we could move faster than hadoop core.

bq. Not sure to completelty understand "encapsulate the protoc version and would get it on
the fly": The hadoop one is quite clever and depending on the protobuf.jar version, it fails
fast if the protoc --version is not the same. Is this what you mean?
I haven't noticed about the failfast. It's great :-). But what we should ideally have is something
that does not require anything installed locally: like surefire for example: you don't have
to install it locally. AFAIK it's not possible.

bq.  A bottom line would be to leave it as such and provide 2 ways to create the protobuf
if needed:
I like that.

                
> Generate the protobuf classes with hadoop-maven-plugin
> ------------------------------------------------------
>
>                 Key: HBASE-9299
>                 URL: https://issues.apache.org/jira/browse/HBASE-9299
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Eric Charles
>
> For now, the protobuf classes are generated once by a dev, and put in src/main/resouce.

> This allows the other dev to not have the correct protoc version available on their machine.
However, when a dev wants to modify the protoc messages, he has to know how to generate the
classes. This could be documented...
> Another approach would be to put a harder requirement on the hbase developers (protoc
available) and let the hadoop-maven-plugin (http://central.maven.org/maven2/org/apache/hadoop/hadoop-maven-plugins/2.0.5-alpha)
to do the work (I have bad experience with other maven protobuf plugins, the hadoop one works
just out of the box).
> I don't think asking to install protoc to build hbase is so difficult, but that's an
additional step between the dev and the artifcat.
> The advantage would be to allow to have different protobuf versions for different hbase
distributions (perfectly possible but quite theorical).
> So
> option 1: We are happy to keep the classes in src/main/java
> option 2: We want to move to hadoop-maven-plugin 
> option 3: I may be short of idea... any other input?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message