hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9275) shell "list" includes "hbase:namespace"
Date Tue, 20 Aug 2013 22:25:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745536#comment-13745536
] 

Nick Dimiduk commented on HBASE-9275:
-------------------------------------

I believe inclusion of "hbase:namespace" is incorrect behavior. Is this not the case?

Instead, I propose modifying [{{HTableDescriptor#isMetaTable()}}|https://github.com/apache/hbase/blob/0.95.2/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java#L423-L430]
to also exclude any table in the "hbase" namespace, effectively honoring ![{{HTableDescriptor#isSystemTable(String)}}|https://github.com/apache/hbase/blob/0.95.2/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java#L432-L442].
This is the logic performed in this branch of [{{HMaster#getTableDescriptors(RpcController,GetTableDescriptorsReq)}}|https://github.com/apache/hbase/blob/0.95.2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L2596-L2602].
                
> shell "list" includes "hbase:namespace"
> ---------------------------------------
>
>                 Key: HBASE-9275
>                 URL: https://issues.apache.org/jira/browse/HBASE-9275
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.95.2
>            Reporter: Nick Dimiduk
>            Assignee: Andrew Purtell
>            Priority: Minor
>
> From the shell "list" operation, we see the "user:namespace" table included in results.
This is different from retrieving a tabling listing from the REST service, which omits that
table.
> The reason appears to be that hbase shell "list" command calls the deprecated {{HBaseAdmin#getTableNames(String)}},
which invokes {{HMaster#getTableNames}}. This implementation has different system table filtering
logic from {{HMaster#getTableDescriptors}}. The latter is the call underlying the REST implementation.
> {noformat}
> hbase(main):004:0> list
> TABLE                                                                               
                                                                                         
                           
> hbase:namespace                                                                     
                                                                                         
                           
> 1 row(s) in 0.0390 seconds
> => #<#<Class:0x16309ee1>:0x66f11de2>
> {noformat}
> {noformat}
> $ curl http://localhost:8080/
> $
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message