hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9262) Make KeyValue.KEY_COMPARATOR default for HFile WriterFactory
Date Mon, 19 Aug 2013 18:12:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744076#comment-13744076
] 

stack commented on HBASE-9262:
------------------------------

+1  I love removed code.  On public APIs, deprecate first I'd say.  Minimize how much we piss
folks off.
                
> Make KeyValue.KEY_COMPARATOR default for HFile WriterFactory
> ------------------------------------------------------------
>
>                 Key: HBASE-9262
>                 URL: https://issues.apache.org/jira/browse/HBASE-9262
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.98.0, 0.95.2
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9262.patch
>
>
> This takes completed work mentioned in HBASE-9247 as a reasonably sized patch to build
upon.
> * Fixed defaults in HFile.Writer factory to default to Key-format-aware comparator (KeyComparator,
later converted to KVComparator) instead of a Key-format oblivious byte[] comparator. (Essentially
all instances require specifying KEY_COMPARATOR – why not just make it the default).
> ** Found that TestSeekTo, TestReseekTo and a handful of others depend on a different
comparator because – HBASE-7845 "breaks" assumptions in these tests.
> * Moved getComparator into TableName. (removed an instanceof bad smell)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message