hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9262) Make KeyValue.KEY_COMPARATOR default for HFile WriterFactory
Date Mon, 19 Aug 2013 18:07:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744075#comment-13744075

Jonathan Hsieh commented on HBASE-9262:

I'll move it to KVUtil and do a pass to catch other instances of this pattern to make it more

What do you think of applying this to 0.95/0.96?  Parts of this starts to remove previously
public (but seemingly esoteric) apis.
> Make KeyValue.KEY_COMPARATOR default for HFile WriterFactory
> ------------------------------------------------------------
>                 Key: HBASE-9262
>                 URL: https://issues.apache.org/jira/browse/HBASE-9262
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.98.0, 0.95.2
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9262.patch
> This takes completed work mentioned in HBASE-9247 as a reasonably sized patch to build
> * Fixed defaults in HFile.Writer factory to default to Key-format-aware comparator (KeyComparator,
later converted to KVComparator) instead of a Key-format oblivious byte[] comparator. (Essentially
all instances require specifying KEY_COMPARATOR – why not just make it the default).
> ** Found that TestSeekTo, TestReseekTo and a handful of others depend on a different
comparator because – HBASE-7845 "breaks" assumptions in these tests.
> * Moved getComparator into TableName. (removed an instanceof bad smell)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message