hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9195) TestFSHDFSUtils is too aggressive
Date Wed, 14 Aug 2013 21:23:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740210#comment-13740210

Jonathan Hsieh commented on HBASE-9195:

More details on why or how a lot of isFileClosed calls cause test destabilization?  Is does
it timeout?  is there a race?

TestShell is not on you.  Can you check if the findbugs is?  (do this before and after the
patch, verify the number is the same).

mvn findbugs:findbugs
grep -oh BugInstance hbase-*/target/findbugs.xml | wc -l
> TestFSHDFSUtils is too aggressive
> ---------------------------------
>                 Key: HBASE-9195
>                 URL: https://issues.apache.org/jira/browse/HBASE-9195
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.95.1
>            Reporter: Himanshu Vashishtha
>            Priority: Minor
>         Attachments: HBase-9195.patch, HBase-9195.patch
> The recoverLease test in this class sets hbase.lease.recovery.pause to 10ms. It causes
that after every 10 ms, it calls isFileClosed (if it is available). Though the test takes
only 3-4 sec, but it makes about 270 isFileClosed calls. This cause test to become somewhat
flaky in our internal testing.
> The proposed fix is to just to increase the pause interval to 100 ms. This reduces the
number of calls to about 30.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message