hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Himanshu Vashishtha (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-9195) Fix TestFSHDFSUtils against java7 test re-ordering
Date Mon, 19 Aug 2013 23:32:52 GMT

     [ https://issues.apache.org/jira/browse/HBASE-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Himanshu Vashishtha updated HBASE-9195:
---------------------------------------

    Description: 
The test methods of TestFSHDFSUtils depends on hbase.lease.recovery.dfs.timeout, which is
overwritten by testIsFileClosed. In case it runs first, it fails testRecoverLease because
it assumes a different value. This makes this test flakey in java7 environment. 

The proposed fix is to let both tests specify the property value in their definition.

  was:
The recoverLease test in this class sets hbase.lease.recovery.pause to 10ms. It causes that
after every 10 ms, it calls isFileClosed (if it is available). Though the test takes only
3-4 sec, but it makes about 270 isFileClosed calls. This cause test to become somewhat flaky
in our internal testing.

The proposed fix is to just to increase the pause interval to 100 ms. This reduces the number
of calls to about 30.

    
> Fix TestFSHDFSUtils against java7 test re-ordering
> --------------------------------------------------
>
>                 Key: HBASE-9195
>                 URL: https://issues.apache.org/jira/browse/HBASE-9195
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.95.1
>            Reporter: Himanshu Vashishtha
>            Priority: Minor
>         Attachments: HBase-9195.patch, HBase-9195.patch, HBase-9195-v1.patch
>
>
> The test methods of TestFSHDFSUtils depends on hbase.lease.recovery.dfs.timeout, which
is overwritten by testIsFileClosed. In case it runs first, it fails testRecoverLease because
it assumes a different value. This makes this test flakey in java7 environment. 
> The proposed fix is to let both tests specify the property value in their definition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message