hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Trezzo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9173) replication_admin#get_peer_state(id) in ruby script pointing to undefined method `getPeerState'
Date Tue, 13 Aug 2013 03:54:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737778#comment-13737778
] 

Chris Trezzo commented on HBASE-9173:
-------------------------------------

bq. Should we add lightweight checks or do something like my patch does?

Maybe both? We could add a getPeerState(id) method to the ReplicationPeers interface. In ReplicationPeersZKImpl,
the getPeerState(id) implementation could just make a call to Zookeeper and return the contents
of the znode. ReplicationSource.shipEdits can still leverage getStatusOfConnectedPeer so that
it caches the PeerState locally. Also, I like the wait on the client side. I would much rather
have it there so we can still leverage the async perf gains on the server side.

Thoughts?

The asynchrony involved with PeerStateTracker and ReplicationTrackerZKImpl definitely makes
things tricky :-)
                
> replication_admin#get_peer_state(id) in ruby script pointing to undefined method `getPeerState'
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9173
>                 URL: https://issues.apache.org/jira/browse/HBASE-9173
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: rajeshbabu
>            Assignee: Jean-Daniel Cryans
>            Priority: Critical
>             Fix For: 0.98.0, 0.95.2
>
>         Attachments: HBASE-9173.patch
>
>
> list_peers is failing because replication_admin#get_peer_state(id) pointing to the method
removed from ReplicationAdmin. We need to read peer state from ReplicationPeer.
> {code}
> hbase(main):003:0> list_peers
>  PEER_ID CLUSTER_KEY STATE
> ERROR: undefined method `getPeerState' for #<Java::OrgApacheHadoopHbaseClientReplication::ReplicationAdmin:0x7e299629>
> Here is some help for this command:
> List all replication peer clusters.
>   hbase> list_peers
> {code}
> {code}
>     # Get peer cluster state
>     def get_peer_state(id)
>       @replication_admin.getPeerState(id)
>     end
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message