hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9167) ServerCallable retries just once if timeout is not integer.max
Date Fri, 09 Aug 2013 05:55:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734425#comment-13734425
] 

Hadoop QA commented on HBASE-9167:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12596997/0.94-9167.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6675//console

This message is automatically generated.
                
> ServerCallable retries just once if timeout is not integer.max
> --------------------------------------------------------------
>
>                 Key: HBASE-9167
>                 URL: https://issues.apache.org/jira/browse/HBASE-9167
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.94.10
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 0.94-9167.patch
>
>
> If callTimeout is not integer.max and throwable is not SocketTimeoutException, we set
the callTimeout to a negative value since endTime is not set yet.  Therefore, the next call
will always throw SocketTimeoutException.
> {noformat}
>     if (this.callTimeout != HConstants.DEFAULT_HBASE_CLIENT_OPERATION_TIMEOUT)
>       if (throwable instanceof SocketTimeoutException
>           || (this.endTime - this.startTime > this.callTimeout)) {
>         throw (SocketTimeoutException) (SocketTimeoutException) new SocketTimeoutException(
>             "Call to access row '" + Bytes.toString(row) + "' on table '"
>                 + Bytes.toString(tableName)
>                 + "' failed on socket timeout exception: " + throwable)
>             .initCause(throwable);
>       } else {
>    ===>     this.callTimeout = ((int) (this.endTime - this.startTime));
>       }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message