hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9164) Convert List<? extends Cell> anti pattern to List<Cell> pattern.
Date Thu, 15 Aug 2013 20:35:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741442#comment-13741442
] 

Hudson commented on HBASE-9164:
-------------------------------

SUCCESS: Integrated in HBase-TRUNK #4397 (See [https://builds.apache.org/job/HBase-TRUNK/4397/])
HBASE-9164 Convert List<? extends Cell> anti pattern to List<Cell> pattern

This patch also starts a refactor of the KVComparator. (jmhsieh: rev 1514400)
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutCombiner.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutSortReducer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverBypass.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestReplicationProtobuf.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java

                
> Convert List<? extends Cell> anti pattern to List<Cell> pattern.
> ----------------------------------------------------------------
>
>                 Key: HBASE-9164
>                 URL: https://issues.apache.org/jira/browse/HBASE-9164
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.95.1
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>            Priority: Blocker
>             Fix For: 0.95.2, 0.96.0
>
>         Attachments: hbase-9164.patch, hbase-9164.v2-95.patch, hbase-9164.v2.patch
>
>
> As described in HBASE-9142, using List<? extends Cell> is an anti pattern that
adds unnecessary typing and casting clutter to the code base.  It would be best to remove
this before we release 0.95.2 or 0.96.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message