hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9141) Replication Znodes Backup Tool
Date Tue, 06 Aug 2013 21:26:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731295#comment-13731295

Ted Yu commented on HBASE-9141:

Nice tool.
+ * Copyright 2009 The Apache Software Foundation
Year is not needed.
+    if (this.fs != null) this.fs.close();
+    if (this.zkw != null) this.zkw.close();
I think this.zkw.close() should be placed in finally block.
+  private void takeBackupOfZnodes() throws Exception {
+    if (ZKUtil.checkExists(zkw, baseReplicationZnode) == -1) return;
Add a log for the above case.
+    for (Znode z : znodesToRestore) {
+      ZKUtil.createWithParents(zkw, z.getPath(), z.getData());
Maybe in a follow-on JIRA, znodesToRestore can be sorted w.r.t. their path. This would reduce
the number of recursive calls to createWithParents().
> Replication Znodes Backup Tool
> ------------------------------
>                 Key: HBASE-9141
>                 URL: https://issues.apache.org/jira/browse/HBASE-9141
>             Project: HBase
>          Issue Type: Improvement
>          Components: migration, Replication
>    Affects Versions: 0.94.10
>            Reporter: Himanshu Vashishtha
>            Assignee: Himanshu Vashishtha
>             Fix For: 0.95.2
>         Attachments: HBase-9141.patch
> While migrating to 0.96, we recommend deleting old znodes so users not face issues like
HBASE-7766, and let HBase create them out of box.
> Though HBase tends to store only ephemeral data in zookeeper, replication has a different
approach. Almost all of its data (state, peer info, logs, etc) is present in zookeeper. We
would like to preserve them in order to not do re-adding of peers, and ensuring complete replication
after we have migrated to 0.96. 
> This jira adds a tool to serialize/de-serialize replication znodes to the underlying
filesystem. This could be used while migrating to 0.96.0.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message