hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9123) Filter protobuf generated code from long line warning
Date Fri, 02 Aug 2013 22:55:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728223#comment-13728223
] 

Ted Yu commented on HBASE-9123:
-------------------------------

Here is the difference between filtered and unfiltered long line warning based on PreCommit
build #6569 :
{code}
TYus-MacBook-Pro:94-hbase tyu$ grep -v 'hbase.protobuf.generated' long-line-6569.txt | wc
      60     488    7268
TYus-MacBook-Pro:94-hbase tyu$ wc long-line-6569.txt
    1622    7597  211734 long-line-6569.txt
{code}
                
> Filter protobuf generated code from long line warning
> -----------------------------------------------------
>
>                 Key: HBASE-9123
>                 URL: https://issues.apache.org/jira/browse/HBASE-9123
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.98.0
>
>         Attachments: 9123.patch
>
>
> For big patch, such as the one for namespace, there would be many changes in the protobuf
generated code.
> See example here: https://builds.apache.org/job/PreCommit-HBASE-Build/6569/console
> We should filter protobuf generated code from long line warning

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message