hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9093) Hbase client API: Restore the writeToWal method
Date Wed, 07 Aug 2013 13:32:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731977#comment-13731977
] 

Jonathan Hsieh commented on HBASE-9093:
---------------------------------------

While trying to get the flume build to work properly, I notice that there was a mistake in
the "restored" methods -- the recently committed patch added #getWriteToWal and #setWriteToWal
when the original APIs were #getWriteToWAL and #setWriteToWAL.   (Wal vs WAL).

http://hbase.apache.org/0.94/apidocs/org/apache/hadoop/hbase/client/Mutation.html#getWriteToWAL()

I'm going to revert on the 0.95 branch and recommit a version that fixes the typo.
                
> Hbase client API: Restore the writeToWal method
> -----------------------------------------------
>
>                 Key: HBASE-9093
>                 URL: https://issues.apache.org/jira/browse/HBASE-9093
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Usability
>    Affects Versions: 0.95.0
>            Reporter: Hari Shreedharan
>             Fix For: 0.95.2
>
>         Attachments: HBASE-9093.patch, HBASE-9093.patch, HBASE-9093.patch
>
>
> The writeToWal is used by downstream projects like Flume to disable writes to WAL to
improve performance when durability is not strictly required. But renaming this method to
setDurability forces us to use reflection to support hbase versions < 95 - which in turn
hits performance, as this method needs to be called on every single write. I recommend adding
the old method back as deprecated and removing it once hbase-95/96 becomes the popular version
used in prod.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message