hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8760) possible loss of data in snapshot taken after region split
Date Mon, 19 Aug 2013 21:45:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744294#comment-13744294
] 

Matteo Bertozzi commented on HBASE-8760:
----------------------------------------

{quote}// TODO-REMOVE-ME: HConnectionManager.isTableAvailable() - When would the above be
removed?{quote}
from 94 can't be removed to keep the compatibility with pre-HBASE-9233 versions
in the trunk patch is not there

{quote}I don't see synchronized (parentsMap) in other part of the patch.{quote}
because other parts are single threaded. There's a restore regions steps that has a thread-pool
underneath, coming from ModifyRegionUtils.createRegions()

{quote}The javadoc above @Override seems to be redundant.{quote}
yeah, I'll remove that

                
> possible loss of data in snapshot taken after region split
> ----------------------------------------------------------
>
>                 Key: HBASE-8760
>                 URL: https://issues.apache.org/jira/browse/HBASE-8760
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 0.94.8, 0.95.1
>            Reporter: Jerry He
>            Assignee: Matteo Bertozzi
>             Fix For: 0.98.0, 0.94.12, 0.96.0
>
>         Attachments: HBase-8760-0.94.8.patch, HBase-8760-0.94.8-v1.patch, HBASE-8760-0.94-v4.patch,
HBASE-8760-0.94-v5.patch, HBASE-8760-0.94-v6.patch, HBASE-8760-0.94-v7.patch, HBASE-8760-0.94-v8-addendum.patch,
HBASE-8760-0.94-v8.patch, HBASE-8760-thz-v0.patch, HBASE-8760-trunk-v8.patch, HBASE-8760-v4.patch,
v4-patch-testing-0.94.zip, v4-patch-testing-0.95.2.zip
>
>
> Right after a region split but before the daughter regions are compacted, we have two
daughter regions containing Reference files to the parent hfiles.
> If we take snapshot right at the moment, the snapshot will succeed, but it will only
contain the daughter Reference files. Since there is no hold on the parent hfiles, they will
be deleted by the HFile Cleaner after they are no longer needed by the daughter regions soon
after.
> A minimum we need to do is the keep these parent hfiles from being deleted. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message