hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8754) Log the client IP/port of the balancer invoker
Date Sun, 18 Aug 2013 04:51:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743142#comment-13743142
] 

stack commented on HBASE-8754:
------------------------------

Thanks for the hint [~qwertymaniac]  There is a RequestContext thread local that has the info.
 See what you think of the 1-line patch.  I can commit if it looks good to you.  It seems
to do the trick.  Here is what shows in logs if I do enable true true, false:

1122 2013-08-17 21:50:15,638 INFO  [RpcServer.handler=4,port=57158] master.HMaster: BalanceSwitch=true
set by stack
1123 2013-08-17 21:50:16,695 INFO  [RpcServer.handler=7,port=57158] master.HMaster: BalanceSwitch=true
set by stack
1124 2013-08-17 21:50:19,175 INFO  [RpcServer.handler=10,port=57158] master.HMaster: BalanceSwitch=false
set by stack


                
> Log the client IP/port of the balancer invoker
> ----------------------------------------------
>
>                 Key: HBASE-8754
>                 URL: https://issues.apache.org/jira/browse/HBASE-8754
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, Usability
>    Affects Versions: 0.90.0
>            Reporter: Harsh J
>             Fix For: 0.96.0
>
>         Attachments: 8754.txt
>
>
> There's no way for any ops to answer today: "Who turned off/on the balancer?". All the
logs print is the state when the RPC call is invoked, nothing else.
> Given this is a critical piece of admin functionality, we should log the IP for it at
least.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message