hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8348) Polish the migration to 0.96
Date Sun, 18 Aug 2013 00:01:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743064#comment-13743064
] 

stack commented on HBASE-8348:
------------------------------

bq. But with replacement, just if we run the same command again we can continue from the place
where its failed. Its simple to use also.

Agree

On the script name, would suggest calling it Upgrade rather than UpgradeTo96.

Regards the text for help, 'This tool helps in upgrading to 0.96.'  -- doesn't it run the
whole upgrade?

Would suggest that the help is outside in the documentation rather than as usage on the script.

Does cluster have to be shut down for the actual upgrade to run?

I'd suggest dividing upgrade into two parts, a --check, and a --execute.

Otherwise, this is looking great.  Between the two of you, you are doing a nice job on a critical
process.  Let me take a look at the patch.






                
> Polish the migration to 0.96
> ----------------------------
>
>                 Key: HBASE-8348
>                 URL: https://issues.apache.org/jira/browse/HBASE-8348
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: rajeshbabu
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: HBASE-8348-approach-2.patch, HBASE-8348-approach-3.patch, HBASE-8348_trunk.patch,
HBASE-8348_trunk_v2.patch, HBASE-8348_trunk_v3.patch
>
>
> Currently, migration works but there's still a couple of rough edges:
>  - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's still on
the filesystem.
>  - Data in ZK needs to be removed manually. Either we fix up the data in ZK or we delete
it ourselves.
>  - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but ROOT is gone
now.
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1 checks,
clear ZK, remove ROOT, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message