hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8348) Polish the migration to 0.96
Date Wed, 21 Aug 2013 01:07:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745682#comment-13745682

stack commented on HBASE-8348:

Why this change?

-  private String masterAddressZNode;
+  public String masterAddressZNode;

Why make a datamember public?  Why not an accessor?

This is unorthodox and is the line too long?

+  private boolean upgradeNS = false, upgradeZnode = false, upgrade = false,
+      checkForHFileV1 = false;

Call the datamembers out individually.

Why different spacing here after the 'if'?

+    if (cmd.hasOption("zk")) upgradeZnode = true;
+    if (cmd.hasOption("execute")) upgrade = true;
+    if(cmd.hasOption("check")) checkForHFileV1 = true;
+    if(che

Suggest you follow general conventions on how to do usage.  Rather than this:

+    System.out.println("This tool runs in two modes: --check, and --execute.");


+    System.out.println("Usage: Upgrade --check|--execute");

Do the above take args?

And see how other commands do options...

Can't you get options to print this out for you anyways?

More to follow.

We need to get something in and then can do patches on top of it....
> Polish the migration to 0.96
> ----------------------------
>                 Key: HBASE-8348
>                 URL: https://issues.apache.org/jira/browse/HBASE-8348
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: rajeshbabu
>            Priority: Critical
>             Fix For: 0.96.0
>         Attachments: HBASE-8348-approach-2.patch, HBASE-8348-approach-2-v2.1.patch, HBASE-8348-approach-2-v2.2.patch,
HBASE-8348-approach-3.patch, HBASE-8348_trunk.patch, HBASE-8348_trunk_v2.patch, HBASE-8348_trunk_v3.patch
> Currently, migration works but there's still a couple of rough edges:
>  - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's still on
the filesystem.
>  - Data in ZK needs to be removed manually. Either we fix up the data in ZK or we delete
it ourselves.
>  - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but ROOT is gone
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1 checks,
clear ZK, remove ROOT, etc.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message