hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Himanshu Vashishtha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8348) Polish the migration to 0.96
Date Tue, 20 Aug 2013 05:18:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744716#comment-13744716
] 

Himanshu Vashishtha commented on HBASE-8348:
--------------------------------------------

Attached is a patch which takes review comments from Stack and Jeffrey into account. It also
has the changes mentioned by Rajesh to abort upgrade in case any HBase process is alive. Key
changes:

a) Made the help crispier (and linked to refguide's migrate 0.96 section).
b) Re-added the Test class TestUpgradeTo96. HFileV1Detector now skips ROOT table.
c) bq. private static byte[] toByteArray(final String clusterKey) {
ReplicationPeer is build in the ZKDataMigrator class, and therefore we no longer need this.
d) bq.  + public String masterAddressZNode;
This is now consistent with all other base znodes (they all are public). I think it is okay.
e) Script now has two parts: --check (checks for HFileV1 and any live process), and --execute
(does the actual upgrade). The detailed help section attached in the previous will have explanation
of other options (upgrade ns, or zk, etc) and it will be incorporated in refguide (as Stack
mentioned).

                
> Polish the migration to 0.96
> ----------------------------
>
>                 Key: HBASE-8348
>                 URL: https://issues.apache.org/jira/browse/HBASE-8348
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: rajeshbabu
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: HBASE-8348-approach-2.patch, HBASE-8348-approach-2-v2.1.patch, HBASE-8348-approach-3.patch,
HBASE-8348_trunk.patch, HBASE-8348_trunk_v2.patch, HBASE-8348_trunk_v3.patch
>
>
> Currently, migration works but there's still a couple of rough edges:
>  - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's still on
the filesystem.
>  - Data in ZK needs to be removed manually. Either we fix up the data in ZK or we delete
it ourselves.
>  - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but ROOT is gone
now.
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1 checks,
clear ZK, remove ROOT, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message