hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7658) grant with an empty string as permission should throw an exception
Date Tue, 20 Aug 2013 00:00:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744539#comment-13744539
] 

Hudson commented on HBASE-7658:
-------------------------------

SUCCESS: Integrated in hbase-0.95-on-hadoop2 #255 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/255/])
HBASE-7658 grant with an empty string as permission should throw an exception (ddas: rev 1515650)
* /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java
* /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/security.rb
* /hbase/branches/0.95/hbase-server/src/main/ruby/shell/commands/grant.rb
* /hbase/branches/0.95/hbase-server/src/main/ruby/shell/commands/revoke.rb

                
> grant with an empty string as permission should throw an exception
> ------------------------------------------------------------------
>
>                 Key: HBASE-7658
>                 URL: https://issues.apache.org/jira/browse/HBASE-7658
>             Project: HBase
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.95.2
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 0.94.7, 0.95.1
>
>         Attachments: HBASE-7658-0.94.patch, HBASE-7658-v0.patch, HBASE-7658-v1.patch
>
>
> If someone specify an empty permission
> {code}grant 'user', ''{code}
> AccessControlLists.addUserPermission() output a log message and doesn't change the permission,
but the user doesn't know about it.
> {code}
> if ((actions == null) || (actions.length == 0)) {
>   LOG.warn("No actions associated with user '"+Bytes.toString(userPerm.getUser())+"'");
>   return;
> }
> {code}
> I think we should throw an exception instead of just logging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message