Return-Path: 
 <issues-return-106880-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4ECBC104FC
	for <apmail-hbase-issues-archive@www.apache.org>;
 Sat, 27 Jul 2013 16:19:51 +0000 (UTC)
Received: (qmail 52172 invoked by uid 500); 27 Jul 2013 16:19:50 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 52105 invoked by uid 500); 27 Jul 2013 16:19:50 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 52068 invoked by uid 99); 27 Jul 2013 16:19:49 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jul 2013 16:19:49 +0000
Date: Sat, 27 Jul 2013 16:19:49 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12660203.1374941932713.123905.1374941989279@arcas>
In-Reply-To: <JIRA.12660203.1374941932713@arcas>
References: <JIRA.12660203.1374941932713@arcas>
Subject: [jira] [Created] (HBASE-9059) Address HBASE-8764 'Some
 MasterMonitorCallable should retry' review
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

stack created HBASE-9059:
----------------------------

             Summary: Address HBASE-8764 'Some MasterMonitorCallable should retry' review
                 Key: HBASE-9059
                 URL: https://issues.apache.org/jira/browse/HBASE-9059
             Project: HBase
          Issue Type: Bug
          Components: master
            Reporter: stack
            Assignee: stack
            Priority: Critical
             Fix For: 0.95.2


Jesse came in w/ some review post-commit.  Let me address in this followup.  Let me paste form our offlist correspondence:

{quote}

+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionOfflineException.java
@@ -24,7 +24,7 @@ import org.apache.hadoop.hbase.exceptions.RegionException;
 
 /** Thrown when a table can not be located */
 @InterfaceAudience.Public
-@InterfaceStability.Stable
+@InterfaceStability.Evolving

Really? Same patch? Come on man - you are doing similar cleanup all over the place (shakes head)... :)
+@InterfaceStability.Stable
+public class RpcRetryingCaller<T> {
Calling this stable as the first time its going in seems a bit presumptuous...

+    this.startTime = EnvironmentEdgeManager.currentTimeMillis();
+    int remaining = (int)(callTimeout - (this.startTime - this.globalStartTime));
+    if (remaining < MIN_RPC_TIMEOUT) {
+      // If there is no time left, we're trying anyway. It's too late.
+      // 0 means no timeout, and it's not the intent here. So we secure both cases by
+      // resetting to the minimum.
+      remaining = MIN_RPC_TIMEOUT;
+    }
+    RpcClient.setRpcTimeout(remaining);

Looks like some new logic... seems reasonable to me, so I'll let it slide this time :)

{quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira