Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 27 Jul 2013 04:21:48 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12660141.1374875544198.123077.1374898908816@arcas>
In-Reply-To: <JIRA.12660141.1374875544198@arcas>
References: <JIRA.12660141.1374875544198@arcas>
Subject: [jira] [Commented] (HBASE-9050) HBaseClient#call could hang
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721519#comment-13721519 ] 

Lars Hofhansl commented on HBASE-9050:
--------------------------------------

Looks good.
I'd say 1000ms is good, as we're just guarding a rare race scenario.
100ms is good too.

+1 either way
                
> HBaseClient#call could hang
> ---------------------------
>
>                 Key: HBASE-9050
>                 URL: https://issues.apache.org/jira/browse/HBASE-9050
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.94.10
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: 0.94-9050.patch
>
>
> In HBaseClient#call, we have
> {code}
>     connection.sendParam(call);                 // send the parameter
>     boolean interrupted = false;
>     //noinspection SynchronizationOnLocalVariableOrMethodParameter
>     synchronized (call) {
>       while (!call.done) {
>         try {
>           call.wait();                           // wait for the result
> {code}
> sendParam could do nothing if the connection is closed right after the call is added into the queue.  Since the connection is closed, we won't get any response, therefore, we won't get any notify call.  So we will keep waiting here for something won't happen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira