Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 26 Jul 2013 22:41:48 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12660141.1374875544198.121894.1374878508871@arcas>
In-Reply-To: <JIRA.12660141.1374875544198@arcas>
References: <JIRA.12660141.1374875544198@arcas>
Subject: [jira] [Commented] (HBASE-9050) HBaseClient#call could hang
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721317#comment-13721317 ] 

Hadoop QA commented on HBASE-9050:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12594463/0.94-9050.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6487//console

This message is automatically generated.
                
> HBaseClient#call could hang
> ---------------------------
>
>                 Key: HBASE-9050
>                 URL: https://issues.apache.org/jira/browse/HBASE-9050
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.94.10
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: 0.94-9050.patch
>
>
> In HBaseClient#call, we have
> {code}
>     connection.sendParam(call);                 // send the parameter
>     boolean interrupted = false;
>     //noinspection SynchronizationOnLocalVariableOrMethodParameter
>     synchronized (call) {
>       while (!call.done) {
>         try {
>           call.wait();                           // wait for the result
> {code}
> sendParam could do nothing if the connection is closed right after the call is added into the queue.  Since the connection is closed, we won't get any response, therefore, we won't get any notify call.  So we will keep waiting here for something won't happen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira