Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 591E110C1B for ; Thu, 11 Jul 2013 19:09:49 +0000 (UTC) Received: (qmail 69616 invoked by uid 500); 11 Jul 2013 19:09:49 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 69583 invoked by uid 500); 11 Jul 2013 19:09:49 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69574 invoked by uid 99); 11 Jul 2013 19:09:49 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jul 2013 19:09:49 +0000 Date: Thu, 11 Jul 2013 19:09:49 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8926) Do not set default GC options in hbase-env.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706124#comment-13706124 ] Enis Soztutar commented on HBASE-8926: -------------------------------------- I think it is rather important to supply a decent out-of-the-box experience. If we do not default to CMS (or G1 later), it will be one more step that the user has to perform. I would rather have a default, which is easily overridable. The default substitution does not have to be in hbase-env. We can do that in hbase-config, which is the logical place. > Do not set default GC options in hbase-env.sh > --------------------------------------------- > > Key: HBASE-8926 > URL: https://issues.apache.org/jira/browse/HBASE-8926 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0, 0.95.2, 0.94.10 > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Trivial > Attachments: 8926.patch > > > Exporting default GC options in HBASE_OPTS from hbase-env.sh by default can interfere with some deployment scenarios. We probably shouldn't be doing that. > Noticed this when using scripts to set up EC2 test clusters for G1 GC. Having "-XX:+UseConcMarkSweepGC" on the command line in that case will cause the JVMs to fail to launch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira