Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 9 Jul 2013 00:31:48 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12656698.1373318536692.15268.1373329908666@arcas>
In-Reply-To: <JIRA.12656698.1373318536692@arcas>
References: <JIRA.12656698.1373318536692@arcas>
Subject: [jira] [Commented] (HBASE-8899) Could not open a region on a server
 where it is being closed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702684#comment-13702684 ] 

stack commented on HBASE-8899:
------------------------------

+1 on commit.  You might address below on commit?

Add comment here because it is opaque that FALSE in this map means an ongoing close.

{code}
-            LOG.warn("Attempted open of " + region.getEncodedName()
+            Boolean closing = regionsInTransitionInRS.get(region.getEncodedNameAsBytes());
{code}

Why not just do if (!closing)? (Let autoboxing provide the rest? Maybe it don't work)

{code}
+            if (!Boolean.FALSE.equals(closing)) { // Only return ALREADY_OPENED if not closing
{code}
                
> Could not open a region on a server where it is being closed
> ------------------------------------------------------------
>
>                 Key: HBASE-8899
>                 URL: https://issues.apache.org/jira/browse/HBASE-8899
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: trunk-8899.patch
>
>
> Looked into the failure of an AM none-flaky test:
> http://54.241.6.143/job/HBase-0.95-Hadoop-2/org.apache.hbase$hbase-server/583/testReport/org.apache.hadoop.hbase.master/TestAssignmentManagerOnCluster/testForceAssignWhileClosing/
> The test failed to open a region on a server where the region was being closed.  Region server just returned ALREADY_OPENED while the region was actually being closed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira