Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14EA4F79C for ; Wed, 17 Jul 2013 05:08:52 +0000 (UTC) Received: (qmail 77272 invoked by uid 500); 17 Jul 2013 05:08:51 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 77242 invoked by uid 500); 17 Jul 2013 05:08:51 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 77232 invoked by uid 99); 17 Jul 2013 05:08:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jul 2013 05:08:51 +0000 Date: Wed, 17 Jul 2013 05:08:51 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8877) Reentrant row locks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710704#comment-13710704 ] Ted Yu commented on HBASE-8877: ------------------------------- +1 > Reentrant row locks > ------------------- > > Key: HBASE-8877 > URL: https://issues.apache.org/jira/browse/HBASE-8877 > Project: HBase > Issue Type: Bug > Components: Coprocessors, regionserver > Reporter: Dave Latham > Assignee: Dave Latham > Fix For: 0.98.0, 0.95.2 > > Attachments: hbase-8877-0.94-microbenchmark.txt, HBASE-8877-0.94.patch, HBASE-8877-0.94-v2.patch, HBASE-8877.patch, hbase-8877-refCounts-microbenchmarks.txt, HBASE-8877-refCounts.patch, HBASE-8877-refCounts-v2.patch, HBASE-8877-refCounts-v3.patch, HBASE-8877-refCounts-v4.patch, HBASE-8877-refCounts-v5.patch, HBASE-8877-v2.patch, HBASE-8877-v3.patch, hbase-8877-v4-microbenchmark.txt, HBASE-8877-v4.patch, HBASE-8877-v5.patch, HBASE-8877-v6.patch, HBASE-8877-v7.patch > > > HBASE-8806 revealed performance problems with batch mutations failing to reacquire the same row locks. It looks like HBASE-8806 will use a less intrusive change for 0.94 to have batch mutations track their own row locks and not attempt to reacquire them. Another approach will be to support reentrant row locks directly. This allows simplifying a great deal of calling code to no longer track and pass around lock ids. > One affect this change will have is changing the RegionObserver coprocessor's methods preBatchMutate and postBatchMutate from taking a {{MiniBatchOperationInProgress> miniBatchOp}} to taking a {{MiniBatchOperationInProgress miniBatchOp}}. I don't believe CPs should be relying on these lock ids, but that's a potential incompatibility. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira