Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 55FA0CCD9 for ; Sun, 14 Jul 2013 13:56:51 +0000 (UTC) Received: (qmail 76436 invoked by uid 500); 14 Jul 2013 13:56:50 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 76412 invoked by uid 500); 14 Jul 2013 13:56:50 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 76399 invoked by uid 99); 14 Jul 2013 13:56:49 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jul 2013 13:56:49 +0000 Date: Sun, 14 Jul 2013 13:56:49 +0000 (UTC) From: "Liang Xie (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8873) minor concurrent issue about filesCompacting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708030#comment-13708030 ] Liang Xie commented on HBASE-8873: ---------------------------------- [~lhofhansl], mind taking eyes on this also cause just a 0.94 issue? thanks > minor concurrent issue about filesCompacting > -------------------------------------------- > > Key: HBASE-8873 > URL: https://issues.apache.org/jira/browse/HBASE-8873 > Project: HBase > Issue Type: Bug > Affects Versions: 0.95.1, 0.94.9 > Reporter: Liang Xie > Assignee: Liang Xie > Attachments: HBase-8873-0.94.txt > > > i am reading compaction code, seems there's a minor thread-safe issue on filesCompacting in both 0.94 and trunk, we guard it with synchronized/lock, except needsCompaction() function. and the fix should sth like this: > synchronized (filesCompacting) { > ... > } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira