Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5E77F10E18 for ; Tue, 2 Jul 2013 22:48:24 +0000 (UTC) Received: (qmail 11313 invoked by uid 500); 2 Jul 2013 22:48:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 11282 invoked by uid 500); 2 Jul 2013 22:48:24 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11273 invoked by uid 99); 2 Jul 2013 22:48:24 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2013 22:48:24 +0000 Date: Tue, 2 Jul 2013 22:48:23 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-8798) Fix a minor bug in shell command with clone_snapshot table error MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-8798: -------------------------- Fix Version/s: 0.98.0 Hadoop Flags: Reviewed Integrated to trunk. Thanks for the review, Matteo and Jerry. > Fix a minor bug in shell command with clone_snapshot table error > ---------------------------------------------------------------- > > Key: HBASE-8798 > URL: https://issues.apache.org/jira/browse/HBASE-8798 > Project: HBase > Issue Type: Bug > Components: shell, snapshots > Affects Versions: 0.94.8, 0.95.1 > Reporter: Jerry He > Assignee: Ted Yu > Priority: Minor > Fix For: 0.98.0 > > Attachments: 8798-trunk-v2.txt, 8798-v3.txt, HBASE-8798-trunk.patch > > > In HBase shell, the syntax for clone_snapshot is: > hbase> clone_snapshot 'snapshotName', 'tableName' > If the target table already exists, we'll get an error. > For example: > ------------------ > hbase(main):011:0> clone_snapshot 'mysnapshot1', 'TestTable' > ERROR: Table already exists: mysnapshot1! > Here is some help for this command: > Create a new table by cloning the snapshot content. > There're no copies of data involved. > And writing on the newly created table will not influence the snapshot data. > Examples: > hbase> clone_snapshot 'snapshotName', 'tableName' > ---------------------- > The bug is in the ERROR message: > *ERROR: Table already exists: mysnapshot1!* > We should output the table name, not the snapshot name. > Currently, in command.rb, we have the output fixed as args.first for TableExistsException: > {code} > def translate_hbase_exceptions(*args) > yield > rescue org.apache.hadoop.hbase.exceptions.TableNotFoundException > raise "Unknown table #{args.first}!" > rescue org.apache.hadoop.hbase.exceptions.NoSuchColumnFamilyException > valid_cols = table(args.first).get_all_columns.map { |c| c + '*' } > raise "Unknown column family! Valid column names: #{valid_cols.join(", ")}" > rescue org.apache.hadoop.hbase.exceptions.TableExistsException > raise "Table already exists: #{args.first}!" > end > {code} > This is fine with commands like 'create tableName ...' but not 'clone_snapshot snapshotName tableName'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira