Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 2 Jul 2013 21:31:21 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12651492.1370554866853.201406.1372800681641@arcas>
In-Reply-To: <JIRA.12651492.1370554866853@arcas>
References: <JIRA.12651492.1370554866853@arcas>
Subject: [jira] [Commented] (HBASE-8703) [WINDOWS] Timed-out processes exit
 with non-zero code causing HealthChecker to report incorrectly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698272#comment-13698272 ] 

Hudson commented on HBASE-8703:
-------------------------------

Integrated in hbase-0.95 #280 (See [https://builds.apache.org/job/hbase-0.95/280/])
    HBASE-8703 [WINDOWS] Timed-out processes exit with non-zero code causing HealthChecker to report incorrectly. ADDENDUM patch to fix flaky test (Revision 1499048)

     Result = FAILURE
enis : 
Files : 
* /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestNodeHealthCheckChore.java

                
> [WINDOWS] Timed-out processes exit with non-zero code causing HealthChecker to report incorrectly
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8703
>                 URL: https://issues.apache.org/jira/browse/HBASE-8703
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.0, 0.95.2
>
>         Attachments: hbase-8703-0.94.patch, hbase-8703_v1-addendum.patch, hbase-8703_v1.patch
>
>
> Hadoop ShellCommandExecutor on timeout, destroys the process, and later checks the exit code. On windows, if process is destroyed, the exit code is non-zero, so ShellCommandExecutor.execute() throws ExitCodeException rather than generic IOException. However, in HealthChecker, on catching ExitCodeException we do not check the timeout. 
> It is unfortunate that Hadoop does not throw an TimeoutException, but provides .isTimedOut() api. And it seems that on timeout on linux, the throwing of the IOException is coincidental:
> {code}
> 2013-06-06 14:17:47,930 WARN  [main] hbase.HealthChecker(79): Caught exception : java.io.IOException: Stream closed
> {code}
> It may not be worth fixing Hadoop for this, but we have to do the correct check anyway. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira