hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9094) Rationalize dependencies; fix analysis complaints about used but non-declared dependencies
Date Wed, 31 Jul 2013 02:13:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724764#comment-13724764
] 

Hadoop QA commented on HBASE-9094:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12595085/dep2.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6535//console

This message is automatically generated.
                
> Rationalize dependencies; fix analysis complaints about used but non-declared dependencies
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9094
>                 URL: https://issues.apache.org/jira/browse/HBASE-9094
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.98.0, 0.95.2
>
>         Attachments: dep2.txt, dep.txt
>
>
> Do a cleanup pass through our dependency set so downstreamers get good picture of what
they need to include looking at pom.
> Poking with dependency plugin, found the following issues:
> + hbase-common is missing listing of a bunch of commons libs
> + Some of our classes make use of slf4j for no good reason.  zk, thrift, netty, and yammer,
use slf4j but no need for us to be in the slf4j managing game... so I undid our use of it
and stop its transitive include everywhere.
> + hbase-examples and hbase-it do not declare includes like hbase-client, hbase-protocol,
etc.
> + hbase-hadoop1-compat depended on log4j but doesn't use it.
> + hbase-prefix-tree depends on hadoop but does not declare it (uses WritiableUtil and
RawComparator -- just two imports... uses the Audience annotations which we could just remove
but still these two critical includes)
> + hbase-server wasn't declaring its use of commons-*.  Also added excludes of transitive
include of log4j by zk and yammer.  Got rid of slf4j as a dependency.
> + Add declarations for used libs such as httpclient and commons-math to top-level pom.
> + Removed setting versions on hadoop1 and hadoop2 profile for slf4j mess.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message