hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9093) Hbase client API: Restore the writeToWal method
Date Tue, 30 Jul 2013 22:43:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724543#comment-13724543
] 

Hadoop QA commented on HBASE-9093:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12595062/HBASE-9093.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6528//console

This message is automatically generated.
                
> Hbase client API: Restore the writeToWal method
> -----------------------------------------------
>
>                 Key: HBASE-9093
>                 URL: https://issues.apache.org/jira/browse/HBASE-9093
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Usability
>    Affects Versions: 0.95.0
>            Reporter: Hari Shreedharan
>             Fix For: 0.98.0, 0.95.2
>
>         Attachments: HBASE-9093.patch
>
>
> The writeToWal is used by downstream projects like Flume to disable writes to WAL to
improve performance when durability is not strictly required. But renaming this method to
setDurability forces us to use reflection to support hbase versions < 95 - which in turn
hits performance, as this method needs to be called on every single write. I recommend adding
the old method back as deprecated and removing it once hbase-95/96 becomes the popular version
used in prod.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message