hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9084) HBase admin flush has a data loss risk even after HBASE-7671
Date Wed, 31 Jul 2013 06:51:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724934#comment-13724934
] 

chunhui shen commented on HBASE-9084:
-------------------------------------

Seems have such a risk.

What about using the following fix:
{code}
try {
        boolean result = internalFlushcache(status);

        if (coprocessorHost != null) {
          status.setStatus("Running post-flush coprocessor hooks");
          coprocessorHost.postFlush();
        }

        status.markComplete("Flush successful");
        return result;
      }catch(DroppedSnapshotException ex){
if(rsServices!=null){
rsServices.abort("Replay of HLog required. Forcing server shutdown", ex);
}
return false;
}

{code}

I think the above code could fix the hole
                
> HBase admin flush has a data loss risk even after HBASE-7671
> ------------------------------------------------------------
>
>                 Key: HBASE-9084
>                 URL: https://issues.apache.org/jira/browse/HBASE-9084
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.95.1, 0.94.10
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Critical
>         Attachments: HBASE-9084-0.94.txt, HBASE-9084.txt
>
>
> see https://issues.apache.org/jira/browse/HBASE-7671?focusedCommentId=13722148&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13722148
> will attach a simple patch soon

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message