hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9058) deleteSnapshot() call may be skipped in TestFlushSnapshotFromClient tests
Date Sat, 27 Jul 2013 15:43:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721663#comment-13721663
] 

Hadoop QA commented on HBASE-9058:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12594540/9058.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6495//console

This message is automatically generated.
                
> deleteSnapshot() call may be skipped in TestFlushSnapshotFromClient tests
> -------------------------------------------------------------------------
>
>                 Key: HBASE-9058
>                 URL: https://issues.apache.org/jira/browse/HBASE-9058
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 9058.patch
>
>
> At the end of each test, we have this call:
>     admin.deleteSnapshot(snapshotName);
> However it is not placed in finally block. When assertion in earlier part of the test
fails (See [1]), snapshot cleanup would be skipped, leading to SnapshotTestingUtils.assertNoSnapshots()
failing for subsequent tests.
> [1]: https://builds.apache.org/job/hbase-0.95-on-hadoop2/197/testReport/org.apache.hadoop.hbase.snapshot/TestFlushSnapshotFromClient/testFlushCreateListDestroy/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message