hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9058) deleteSnapshot() call may be skipped in TestFlushSnapshotFromClient tests
Date Sat, 27 Jul 2013 15:03:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721647#comment-13721647
] 

Matteo Bertozzi commented on HBASE-9058:
----------------------------------------

nope, just for each admin.listSnapshot() deleteSnapshot() should be fine, since each test
assert that no snapshot.
There're other tests that does this
                
> deleteSnapshot() call may be skipped in TestFlushSnapshotFromClient tests
> -------------------------------------------------------------------------
>
>                 Key: HBASE-9058
>                 URL: https://issues.apache.org/jira/browse/HBASE-9058
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Priority: Minor
>
> At the end of each test, we have this call:
>     admin.deleteSnapshot(snapshotName);
> However it is not placed in finally block. When assertion in earlier part of the test
fails (See [1]), snapshot cleanup would be skipped, leading to SnapshotTestingUtils.assertNoSnapshots()
failing for subsequent tests.
> [1]: https://builds.apache.org/job/hbase-0.95-on-hadoop2/197/testReport/org.apache.hadoop.hbase.snapshot/TestFlushSnapshotFromClient/testFlushCreateListDestroy/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message